Repository navigation
fix: chat scroll re-stick, text-block joins, topic_worthy rehydrate - #42
Merged
Merged
Conversation
… blank line Two persona-loop findings: - Stick-to-bottom died mid-turn: the scroll event of our own programmatic bottom-scroll fires after paint, so a fast delta rendering in between made the recompute read the grown height as "user scrolled away" and follow froze for the rest of the turn. Programmatic scrolls are now counted and their events consumed (reduceScrollEvent); only user scrolls recompute, and a wheel gesture clears the queue so the user can always scroll away. - assistant_text blocks joined mid-sentence in reply/finalText; they now join with a blank line (matches the hub's new streamed separator). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A stale unstick (user scrolled up during an earlier turn — or a scroll event
race in environments where programmatic scrolls fire no events) silently
froze follow for every later turn: nothing ever set stick back to true.
Sending a message or starting a new topic is an unambiguous 'show me the
reply', so both now force {pending: 0, stick: true}.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The hub's topic_worthy signal is a recorded chat event, but the client kept it only in memory: after a refresh the bar vanished while the agent's reply still invited clicking it — a dead end (persona-loop run 4). Rehydrate now restores it, unless a later topic_drafted superseded it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persona-loop checkpoint, three commits (head f349055):
assets/distrebuilt and committed. JS tests green.🤖 Generated with Claude Code