Skip to content

fix: escape PHP_VERSION in the minimum-PHP-version admin notice - #55

Merged
SteveJonesDev merged 3 commits into
mainfrom
claude/wordpress-plugin-review-51r2wd
Jul 25, 2026
Merged

fix: escape PHP_VERSION in the minimum-PHP-version admin notice#55
SteveJonesDev merged 3 commits into
mainfrom
claude/wordpress-plugin-review-51r2wd

Conversation

@SteveJonesDev

@SteveJonesDev SteveJonesDev commented Jul 25, 2026

Copy link
Copy Markdown
Member

esc_html__() only escapes the format string, so the interpolated
PHP_VERSION value reached output unescaped. Escape the replacement
value itself.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy

Summary by CodeRabbit

  • Documentation
    • Added source code and build instructions, including asset locations, rebuild commands, and bundled library details.
    • Updated packaging guidance and verification steps for the settings sidebar logo.
  • Security
    • Improved safety when displaying the current PHP version in admin warnings.
  • Packaging
    • Clarified why composer.json is included in distributed plugin archives while preserving other exclusions.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c161bf5-e0f0-457d-b020-35c8047c8577

📥 Commits

Reviewing files that changed from the base of the PR and between 89b5372 and 13214ed.

📒 Files selected for processing (4)
  • .claude/skills/package-plugins/SKILL.md
  • .distignore
  • boardscribe.php
  • readme.txt

Walkthrough

Packaging guidance, release archive exclusions, source-build documentation, and escaping of the displayed PHP version in the minimum-version notice were updated.

Changes

Packaging and output hardening

Layer / File(s) Summary
Packaging rules and source-build documentation
.claude/skills/package-plugins/SKILL.md, .distignore, readme.txt
Packaging rules and manifest expectations were updated, composer.json was documented as included in release archives, and source locations, asset mappings, build commands, and bundling expectations were added to the readme.
PHP version notice escaping
boardscribe.php
The minimum-PHP admin notice now HTML-escapes the displayed PHP_VERSION value.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: pattonwebz

Poem

I’m a rabbit packing zips with care,
SVG logos tucked inside with flair.
Source paths bloom and build notes shine,
Escaped PHP keeps notices fine.
Hop, hop—the release is aligned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main code change: escaping PHP_VERSION in the minimum-PHP-version admin notice.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

SteveJonesDev and others added 3 commits July 25, 2026 14:34
esc_html__() only escapes the format string, so the interpolated
PHP_VERSION value reached output unescaped. Escape the replacement
value itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
WP.org guideline 4 requires public access to the source behind any
compiled asset, and assets/build/ ships minified while the repo is
private. Ship src/, webpack.config.js and package.json in the release
zip and document in readme.txt which bundle comes from which source
directory, that no third-party JS is bundled, and how to rebuild.

Also syncs the .distignore denylist with the packaging allowlist:
composer.json ships (Plugin Check's missing_composer_json_file), and
the settings logo is logo.svg, not logo.png.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
…src/

Reverts the zip-side half of the previous commit: with
equalizedigital/boardscribe public, WP.org guideline 4 is satisfied by
linking the repo from readme.txt, so src/, webpack.config.js and
package.json stay out of the release zip. The readme's build steps and
bundle/source mapping stay, now pointing at the repository.

.distignore and the packaging recipe both record what would have to
change if the repo ever went private again. The composer.json and
logo.svg fixes from the previous commit are unaffected.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
@SteveJonesDev
SteveJonesDev force-pushed the claude/wordpress-plugin-review-51r2wd branch from a53b6b5 to 13214ed Compare July 25, 2026 14:34
@SteveJonesDev
SteveJonesDev merged commit 2cf5a3a into main Jul 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant