fix: escape PHP_VERSION in the minimum-PHP-version admin notice - #55
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughPackaging guidance, release archive exclusions, source-build documentation, and escaping of the displayed PHP version in the minimum-version notice were updated. ChangesPackaging and output hardening
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
esc_html__() only escapes the format string, so the interpolated PHP_VERSION value reached output unescaped. Escape the replacement value itself. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
WP.org guideline 4 requires public access to the source behind any compiled asset, and assets/build/ ships minified while the repo is private. Ship src/, webpack.config.js and package.json in the release zip and document in readme.txt which bundle comes from which source directory, that no third-party JS is bundled, and how to rebuild. Also syncs the .distignore denylist with the packaging allowlist: composer.json ships (Plugin Check's missing_composer_json_file), and the settings logo is logo.svg, not logo.png. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
…src/ Reverts the zip-side half of the previous commit: with equalizedigital/boardscribe public, WP.org guideline 4 is satisfied by linking the repo from readme.txt, so src/, webpack.config.js and package.json stay out of the release zip. The readme's build steps and bundle/source mapping stay, now pointing at the repository. .distignore and the packaging recipe both record what would have to change if the repo ever went private again. The composer.json and logo.svg fixes from the previous commit are unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
SteveJonesDev
force-pushed
the
claude/wordpress-plugin-review-51r2wd
branch
from
July 25, 2026 14:34
a53b6b5 to
13214ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esc_html__() only escapes the format string, so the interpolated
PHP_VERSION value reached output unescaped. Escape the replacement
value itself.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RBapcGQamKrynEaeWadMBy
Summary by CodeRabbit
composer.jsonis included in distributed plugin archives while preserving other exclusions.