Skip to content

feat: provide git and pipeline info to sub pipelines#1664

Merged
nilsgstrabo merged 10 commits intomasterfrom
1598-provide-git-commit-hash-to-subpipeline
Apr 15, 2026
Merged

feat: provide git and pipeline info to sub pipelines#1664
nilsgstrabo merged 10 commits intomasterfrom
1598-provide-git-commit-hash-to-subpipeline

Conversation

@nilsgstrabo
Copy link
Copy Markdown
Contributor

No description provided.

@nilsgstrabo nilsgstrabo self-assigned this Apr 9, 2026
@nilsgstrabo nilsgstrabo linked an issue Apr 9, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a structured “radix” Tekton object parameter to sub-pipelines so each sub-pipeline (and its tasks) receives consistent git + pipeline metadata (pipeline type, environment, clone URL, git ref/type, commit, tags).

Changes:

  • Introduces model.SubPipelineParams and stores per-environment values on PipelineInfo.
  • Injects a radix object ParamSpec into generated sub-pipeline Pipelines/Tasks and wires PipelineTask params to reference $(params.radix.<prop>).
  • Ensures RunPipelinesStep includes the radix object param on created PipelineRuns; adds utilities + tests for object-param generation.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pipeline-runner/steps/runpipeline/step.go Adds error-returning build flow and appends radix object param to PipelineRun params.
pipeline-runner/steps/runpipeline/step_test.go Updates tests to assert presence/content of the radix param and revised param behavior.
pipeline-runner/steps/preparepipeline/step.go Builds per-env sub-pipeline params and injects radix param spec + task param references into generated Tekton resources.
pipeline-runner/steps/preparepipeline/step_test.go Adds assertions for radix ParamSpec/Param wiring and validates EnvironmentSubPipelineParams.
pipeline-runner/model/pipelineInfo.go Adds EnvironmentSubPipelineParams and SubPipelineParams helpers to produce Tekton param/spec/reference.
pipeline-runner/internal/subpipeline/params.go New reflection-based helpers to generate Tekton object ParamSpec/Param/reference from tagged structs.
pipeline-runner/internal/subpipeline/params_test.go Unit tests for object param/spec/reference generation and error cases.
.vscode/launch.json Updates local debug args (commit id; removes reserved DNS aliases args).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pipeline-runner/steps/runpipeline/step.go Outdated
Comment thread pipeline-runner/steps/preparepipeline/step.go
Comment thread pipeline-runner/steps/preparepipeline/step.go
Comment thread pipeline-runner/steps/preparepipeline/step.go
Comment thread pipeline-runner/internal/subpipeline/params.go Outdated
nilsgstrabo and others added 6 commits April 13, 2026 16:20
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@nilsgstrabo nilsgstrabo marked this pull request as ready for review April 15, 2026 09:34
@nilsgstrabo nilsgstrabo requested a review from Richard87 April 15, 2026 09:34
@nilsgstrabo nilsgstrabo merged commit 0d61554 into master Apr 15, 2026
23 of 24 checks passed
@nilsgstrabo nilsgstrabo deleted the 1598-provide-git-commit-hash-to-subpipeline branch April 15, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide Git Commit hash - SubPipeline

3 participants