feat: provide git and pipeline info to sub pipelines#1664
Merged
nilsgstrabo merged 10 commits intomasterfrom Apr 15, 2026
Merged
feat: provide git and pipeline info to sub pipelines#1664nilsgstrabo merged 10 commits intomasterfrom
nilsgstrabo merged 10 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a structured “radix” Tekton object parameter to sub-pipelines so each sub-pipeline (and its tasks) receives consistent git + pipeline metadata (pipeline type, environment, clone URL, git ref/type, commit, tags).
Changes:
- Introduces
model.SubPipelineParamsand stores per-environment values onPipelineInfo. - Injects a
radixobjectParamSpecinto generated sub-pipeline Pipelines/Tasks and wires PipelineTask params to reference$(params.radix.<prop>). - Ensures
RunPipelinesStepincludes theradixobject param on created PipelineRuns; adds utilities + tests for object-param generation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pipeline-runner/steps/runpipeline/step.go | Adds error-returning build flow and appends radix object param to PipelineRun params. |
| pipeline-runner/steps/runpipeline/step_test.go | Updates tests to assert presence/content of the radix param and revised param behavior. |
| pipeline-runner/steps/preparepipeline/step.go | Builds per-env sub-pipeline params and injects radix param spec + task param references into generated Tekton resources. |
| pipeline-runner/steps/preparepipeline/step_test.go | Adds assertions for radix ParamSpec/Param wiring and validates EnvironmentSubPipelineParams. |
| pipeline-runner/model/pipelineInfo.go | Adds EnvironmentSubPipelineParams and SubPipelineParams helpers to produce Tekton param/spec/reference. |
| pipeline-runner/internal/subpipeline/params.go | New reflection-based helpers to generate Tekton object ParamSpec/Param/reference from tagged structs. |
| pipeline-runner/internal/subpipeline/params_test.go | Unit tests for object param/spec/reference generation and error cases. |
| .vscode/launch.json | Updates local debug args (commit id; removes reserved DNS aliases args). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Richard87
approved these changes
Apr 15, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.