fix: clarify inherited key display#99
Closed
IgorArkhipov wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://t.me/c/1464748383/37027/132146
Inherit(KC_TRNS) was rendered as the keycode from a lower-numbered layer in several UI and layout-export views. This suggested that the displayed key would always run, even though firmware resolution instead follows the active layer stack.Fix
Inheritassignment as a dimmed▽marker instead of resolving and displaying a lower-layer keycode.Nonebehavior unchanged; this PR only corrects the representation ofInherit.Verification
cargo test --bin entropy -- --quiet: 321 passed.rustfmt --checkandgit diff --check: passed.