Skip to content

fix: clarify inherited key display#99

Closed
IgorArkhipov wants to merge 2 commits into
ergohaven:mainfrom
IgorArkhipov:igor/fix-inherit-display
Closed

fix: clarify inherited key display#99
IgorArkhipov wants to merge 2 commits into
ergohaven:mainfrom
IgorArkhipov:igor/fix-inherit-display

Conversation

@IgorArkhipov

@IgorArkhipov IgorArkhipov commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Problem

https://t.me/c/1464748383/37027/132146

Inherit (KC_TRNS) was rendered as the keycode from a lower-numbered layer in several UI and layout-export views. This suggested that the displayed key would always run, even though firmware resolution instead follows the active layer stack.

Fix

  • Render every Inherit assignment as a dimmed marker instead of resolving and displaying a lower-layer keycode.
  • Apply the marker consistently to keyboard keys, encoder rotation and press assignments, Sticky Layout preview, and PNG/SVG/PDF layout exports.
  • Keep None behavior unchanged; this PR only corrects the representation of Inherit.

Verification

  • cargo test --bin entropy -- --quiet: 321 passed.
  • Scoped rustfmt --check and git diff --check: passed.

@kissetfall kissetfall closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants