Repository navigation
Credit Louie Mantia in Help and colour the title from the chosen colour - #15
Merged
Merged
Conversation
Help now ends with "Based on a design by Louie Mantia", linking to lmnt.me. That closes the old request for a design credit; it lives in Help rather than a tooltip so keyboard and touch users can reach it. Hovering the title hops its letters and walks them from the hue on show to its neighbours, 15° apart. With a pick, they take its saturation and brightness, darkening only as far as WCAG's 3:1 large-text minimum against the page needs. The page background moves into pageBackground so the title checks against the same colour. Closes #3
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Summary
The design credit goes in Help, not a tooltip, so keyboard and touch users can reach it. Hovering the title now gives you a small treat: the letters hop and take on the colour you've chosen.
How each letter is coloured on hover:
The page's background moves into
pageBackgroundinsrc/picker/color.ts, so the page and the title use the same colour.Evidence
After: checked in Chromium at 1280×900 and 390×844 with
verify-huebo:Help ends with "Based on a design by Louie Mantia", which opens lmnt.me in a new tab.
Hovering the title at different colours:
/200#1682B8 → #4F17BF(blue to indigo)/20/75/88#BD5E2F → #628221(orange to olive)/200/12/100#707A80, darkened from a pick too pale to readScreen readers still announce the heading as "Huebo", not "H u e b o".
src/picker/__tests__/wordmark-colours.test.ts:pnpm checkpasses: 124 tests.Merge Danger
Door: two-way
It only changes copy and hover styles, so reverting is clean. The hover colour uses the pick's saturation and brightness, but that's one line in
wordmarkColours(color.pick ?? UNPICKED) if you'd rather drop it.Blast Radius: header
Headernow takescolor, so both layouts pass it. The Help popover gets one line taller. The title's letters are now separate inline-block spans, but its size doesn't change, so nothing shifts.