Repository navigation
Build Help, Copy's confirmation and the format radios from the platform - #21
Merged
Merged
Conversation
Base UI was 135 KB of a 492 KB script, and we used it for three small parts. Help is now a <dialog popover>, the confirmation is a manual popover anchored to Copy, and the format picker is plain radio inputs. The script drops to 357 KB (165 KB to 118 KB gzipped). I ran the same script against master and this branch. The animations match frame for frame, Help's screenshots match pixel for pixel, and the new Help and card tests pass on both. Two Base UI behaviours had to be added by hand: focus moves to the link when Help opens, and goes back to Help after a click outside or a Tab out. What we give up: the confirmation is no longer a focusable dialog in a Notifications landmark, so F6, swipe to dismiss and pause on hover are gone. Screen readers now hear it through the app's announcer. ADR 0007 has the reasoning, and CODING_STANDARDS no longer points at Base UI.
Links with target="_blank" get a ↗ after them. CSS alt text makes screen readers say "Link to external site" instead of the arrow. The arrow is inline-block so the link's underline doesn't run under it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
A test that works out its expected value the same way the code does passes no matter what the code does. The standards now say so, and say what to expect instead.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base UI was 135 KB of a 492 KB script, and we only used it for three parts. They now come from the platform.
ADR 0007 has the reasoning. CODING_STANDARDS and the verify-huebo recipes no longer point at Base UI.
A second commit adds a ↗ after links that open a new tab. Screen readers hear "Link to external site" instead of the arrow.
Evidence
index.js491.9 KB, 164.7 KB gzippedAfter:
index.js356.9 KB, 117.8 KB gzipped (−27.4%, −28.5%)I ran one agent-browser script against
masterand against this branch, in the same Chromium:The new browser tests pass on both builds:
pnpm checkpasses, with 140 tests.Merge Danger
Door: two-way
A revert brings Base UI back, and nothing stored or linked depends on this change.
Blast Radius: popups
overlaytransitions drop the popup out of the top layer as soon as it starts to close.