feat(mac): add balanced quota peek and ring-to-bar motion - #101
ericjypark wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughChangesQuota gauge and peek pill
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant IslandRootView
participant PeekPillOverlay
participant NotchPeekPill
participant CompactQuotaGauge
IslandRootView->>PeekPillOverlay: configure gauge content and reveal progress
PeekPillOverlay->>NotchPeekPill: pass content mode and gauge dimensions
NotchPeekPill->>CompactQuotaGauge: render gauge mode
CompactQuotaGauge-->>NotchPeekPill: display quota path and text
NotchPeekPill-->>PeekPillOverlay: return rendered pill
PeekPillOverlay-->>IslandRootView: display peek overlay
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change reworks how quota information is shown in the notch peek area, adds localized labels, and narrows the peek silhouette. The concerns raised during review did not hold up: the quota views compile as written, and screen-reader users still receive quota and reset information in the states where it is visible. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 7 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Selecting one provider now uses both notch tabs: its logo stays on the left and a compact quota ring appears on the right. Hovering unfolds the ring into a usage bar while revealing the reset countdown. With two providers, each side shows the percentage above the reset time.
Validation: the full Swift regression runner, including 1,228 gauge geometry checks; universal build and demo smoke launch; native 24 pt and 38 pt layouts, one/two providers, long countdowns, zero/missing readings, and interrupted transitions. Native captures verify layout and endpoints; physical hover frame pacing was not measured.
Summary by CodeRabbit
New Features
Improvements
Tests