feat(windows): add native app and installer pipeline - #102
Open
ericjypark wants to merge 1 commit into
Open
ericjypark wants to merge 1 commit into
ericjypark wants to merge 1 commit into
Conversation
|
Important Review skippedToo many files! This PR contains 217 files, which is 117 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (15)
📒 Files selected for processing (217)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3a0377cd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| protected override async Task<GithubRelease[]> GetReleases(bool includePrereleases) | ||
| { | ||
| // Mac-only releases must not hide the most recent Windows installer. | ||
| var json=await Downloader.DownloadString("https://api.github.com/repos/ericjypark/codex-island/releases?per_page=100",GetRequestHeaders("application/vnd.github+json")); |
There was a problem hiding this comment.
After more than 100 newer macOS-only releases, the requested endpoint returns only that first page, so the channel-specific filter produces no Windows feed even though an older Windows release is still available. Installed Windows clients will then report that updates have not been published, contradicting the intended behavior that Mac-only releases do not hide the newest Windows installer; follow GitHub pagination (or otherwise search beyond the first page) before filtering.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the first Windows implementation of CodexIsland: a native floating pill that reveals quotas on hover and expands into usage, local cost history, calendar, and share-card views.
Validation: 399 Windows logic checks, 9 publisher safeguard tests, and 30 card rendering checks pass. Existing native coverage includes provider/settings flows, history, cards, motion, and startup. The current packaged app source passed 25 introduction checks plus 3 executable startup/restart checks per architecture in Windows 11 ARM at 200% scaling; x64 ran under emulation. Both x64 and ARM64 installers were built and their manifests/checksums verified during candidate preparation. CI rebuilds the PR snapshot.
Known limits: real Codex and Antigravity requests were verified; Claude/Grok account acceptance remains incomplete. Full Mac visual/behavior parity and the reported stutter on a physical Windows PC are not claimed. Scope and measured performance limits are documented in windows/PARITY.md and windows/PERFORMANCE.md.