Skip to content

fix: clear Sparkle xattrs without following symlinks - #72

Closed
bbnotcode wants to merge 1 commit into
ericjypark:mainfrom
bbnotcode:codex/xattr-split
Closed

bbnotcode wants to merge 1 commit into
ericjypark:mainfrom
bbnotcode:codex/xattr-split

Conversation

@bbnotcode

Copy link
Copy Markdown
Contributor

What

Changes both build-time cleanup calls from xattr -c to xattr -cs.

Why

Sparkle contains symlinked framework paths. Avoiding symlink traversal prevents resource-fork metadata from surviving or being reintroduced during signing.

Validation

  • Bash syntax check
  • Diff whitespace checks

Split from #67 following maintainer feedback.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bbnotcode, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b5c9581d-2ceb-4026-8669-2fee8a863f61

📥 Commits

Reviewing files that changed from the base of the PR and between 3b78b69 and a33b3c6.

📒 Files selected for processing (1)
  • build.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a33b3c654f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread build.sh
if [[ -d "$XPC_PATH" ]]; then
# File Provider may reattach FinderInfo to package directories after a
# recursive xattr pass, so clear every entry immediately before signing.
find "$XPC_PATH" -exec xattr -cs {} \;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear package directories after their descendants

When the build directory is in a File Provider-backed folder—the scenario this cleanup targets—find visits each directory before walking its children by default, so FinderInfo can be reattached while those descendants are accessed and remain present when codesign runs. The macOS find manual documents -d as depth-first traversal (equivalent to -depth); use it for both cleanup passes so each package directory is cleared only after its contents have been visited. macOS find(1)

Useful? React with 👍 / 👎.

@ericjypark

Copy link
Copy Markdown
Owner

Closing for now — today's clean universal build (and CI's) passes codesign without any xattr cleanup, so this guards against a failure this repo doesn't currently exhibit. The PR body also describes changing existing xattr -c calls, but build.sh has none — the diff adds new passes. If you're hitting an actual "resource fork / Finder information not allowed" codesign failure on a stock checkout, please open an issue with the error output and environment (File Provider / iCloud-synced checkout?) and we'll revisit — likely with a batched find … -exec xattr -cs {} + form.

@ericjypark ericjypark closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants