-
Notifications
You must be signed in to change notification settings - Fork 53
feat: add rollout-backed Codex task status #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bbnotcode
wants to merge
9
commits into
ericjypark:main
Choose a base branch
from
bbnotcode:codex/task-status-split
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7aa55c4
feat: add rollout-backed Codex task status
bbnotcode 935de3a
feat: add Codex task status sounds
bbnotcode cad721c
fix: preserve long-running Codex task state
bbnotcode 089f996
fix: address task status review feedback
bbnotcode 1f3fa59
fix: suppress repeated unavailable snapshots
bbnotcode be962f4
fix: notify for every Codex task completion
bbnotcode 1d9e5c0
fix: distinguish Codex task alerts
bbnotcode 8264e0f
fix: harden Codex task monitoring lifecycle
bbnotcode 3236051
docs: explain Codex task status alerts
bbnotcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove unsupported approval behavior from the documentation.
The README claims approval detection and approval-specific sounds, but the current contract supports only running, idle, cancelled, error, and unavailable, with completion and attention sounds.
README.md#L202-L205: removewaiting for approvaland therequest_permissionsapproval-detection claim.README.md#L209-L210: removeapproval uses Pingand the separate cancellation/error mappings.📍 Affects 1 file
README.md#L202-L205(this comment)README.md#L209-L210🤖 Prompt for AI Agents