fix: stop rendering the loading sweep while idle - #96
ericjypark wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe loading sweep now renders only during visible usage or cost refreshes. Low-power mode continues to gate the ambient halo separately. Related comments now describe the updated behavior. ChangesLoading sweep behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The loading sweep is limited to visible refreshes without an identified regression, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing because this work was created from a misunderstanding of the requested task. |
The visible island kept its 30 Hz angular-gradient
TimelineViewrunning whenever Low Power Mode was off, including between refreshes. On the current Mac that held CodexIsland around 19–22% CPU while idle.Limit the rotating sweep to active usage or cost refreshes while preserving the steady cobalt halo, alert tint, occlusion behavior, and Low Power Mode treatment. In the same idle UI state, the changed build measured 0.1–0.3% CPU; manual refresh still showed the sweep state and returned to the normal synced state.
Validation:
./scripts/run-tests.shSU_FEED_URL= ./build.shSummary by CodeRabbit