Fix QR role model and merchant scan completion FIXED#108
Open
Mitch5000 wants to merge 1 commit into
Open
Conversation
|
@Mitch5000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Fix Summary — Issue #70: MerchantInbox QR Scanner
Problem Identified
The MerchantInbox.tsx component had a broken QR scanner flow: it scanned a QR but only displayed the raw payload string without parsing it, validating state, or calling any backend endpoint. There was also a role conflict between the backend (seller calls lock→reveal, buyer calls complete) and the UX expectation that the merchant scans a QR and completes the trade. The cash-out flow was not end-to-end.
UX Contract Resolution
The fix aligns the UX with the backend's existing role model:
Seller (merchant): calls lock → reveal → shows QR with HTLC secret
Buyer: receives QR → calls complete (which releases funds on-chain)
Merchant scanner: scans buyer QR to validate and confirm the trade details (participant, state, expiry) — NOT to complete it. This provides a security check without breaking the HTLC flow.
Closes #70