Fix CI editable-install (PEP 639); document dual-track SageMath/PyTorch testing - #2
Merged
Merged
Conversation
…th/PyTorch testing CI's Track B (and main, red since 2026-05-12) failed at `pip install -e .` with setuptools >= 77 enforcing PEP 639: the project declared both a SPDX `license = "MIT"` expression AND the deprecated `License :: OSI Approved :: MIT License` classifier, which is now an error. Remove the classifier and bump the build requirement to setuptools >= 77. Verified: editable install now builds cleanly in a fresh venv (was the exact failing step). Also adds a README section "How it's tested — and a SageMath-on-CI recipe you can borrow": explains the two-track suite (symbolic SageMath via micromamba, discrete PyTorch via pip) and shows the conda-forge + `sage -python -m pytest` pattern, since getting SageMath into CI is a common stumbling block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make CI green again + document the dual-track testing
Fix: editable install fails under setuptools ≥ 77 (PEP 639)
Track B— andmain— have been red since 2026-05-12, but not because of atest:
pip install -e ".[dev,ml]"errored before any test ran withpyproject.tomldeclared both the SPDXlicense = "MIT"expression and thedeprecated
License ::classifier; newer setuptools rejects the combination.This PR removes the classifier and bumps the build requirement to
setuptools>=77. Verified locally: the editable install now builds cleanly in afresh venv (the exact step that was failing).
Docs: a SageMath-on-CI recipe for learners
Adds a short README section explaining the two-track suite (symbolic SageMath via
micromamba/conda-forge, discrete PyTorch via pip) and the
micromamba run -n sage sage -python -m pytestpattern — getting SageMath intoGitHub Actions is a common stumbling block, and this repo is a working template.