Fix Gemini Strategy & Disable External Calls#3
Conversation
- Fixed `gemini_strategy` to correctly handle batches and set dimension to 512. - Disabled external communication in `RegistryClient` and `mcp_public.py` to resolve SSL errors. - Verified DTO field existence and delete route. - Updated `langchain-text-splitters` dependency.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This PR addresses critical issues identified in review and user feedback:
lpm_kernel/common/strategy/strategy_gemini.pyto correctly iterate over text chunks when generating embeddings (fixing the batching bug) and explicitly setoutput_dimensionality=512.lpm_kernel/api/domains/upload/routes.pyandclient.py(andmcp/mcp_public.py) to remove all calls to external "Second Me" servers (app.secondme.io), replacing them with local mock responses. This resolves the reported SSL certificate verification errors.langchain-text-splitterstopyproject.tomlto support the updated imports.UserLLMConfigDTOalready contains theprovider_typefield and thatdelete_fileroute exists inmemories/routes.py.PR created automatically by Jules for task 5401678453832845914 started by @ericzhoun