.github: enable excessive-permissions audit — final #21132 cleanup - #22694
Merged
AskAlexSharov merged 1 commit intoJul 23, 2026
Merged
Conversation
…audit Final step of the #21132 excessive-permissions cleanup. - test-fuzz: move issues: write from the workflow level to the notify job, the only job that opens/updates the tracking issue. The fuzz matrix job keeps contents: read. - zizmor.yml: replace the blanket excessive-permissions disable with a per-file ignore of ci-gate.yml. ci-gate orchestrates the reusable test leaves and a called workflow's token permissions are capped by the caller, so its workflow-level actions: write is the cap every self-cancelling leaf needs for gh run cancel, and pull-requests: write drives the gate's own dequeuePullRequest mutation — neither can be scoped to a single job. With docker-tags.yml removed (#22688), the excessive-permissions audit now reports no findings.
lystopad
requested review from
AskAlexSharov,
mriccobene and
yperbasis
as code owners
July 23, 2026 12:32
AskAlexSharov
approved these changes
Jul 23, 2026
AskAlexSharov
enabled auto-merge
July 23, 2026 13:01
AskAlexSharov
deleted the
feature/lystopad/zizmor-excessive-perms-final-21132
branch
July 23, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR of the zizmor
excessive-permissionscleanup — closes #21132 (with #22688).Follows #22662, #22677, #22687 (and the dead-workflow removal #22688).
What
test-fuzz.yml— moveissues: writefrom the workflow level to thenotifyjob (the only job that opens/updates thenightly-fuzztracking issue). The fuzz matrix job keepscontents: read..github/zizmor.yml— replace the blanketexcessive-permissions: disable: truewith a per-fileignoreof justci-gate.yml, and enable the audit for every other workflow.Why
ci-gateis ignored rather than scopedci-gateorchestrates the reusable test leaves. Per GitHub's rules, a called workflow'sGITHUB_TOKENpermissions are capped by the caller — so ci-gate's workflow-level grants are not "for itself", they're the ceiling every leaf inherits:actions: writeis the cap that lets all ~12 self-cancelling leaves (scoped in .github: scope actions: write to merge-queue self-cancel jobs (#21132) #22677/.github: least-privilege permissions for docker/hive/kurtosis workflows (#21132) #22687) actually rungh run cancelon merge-queue failure. Dropping it silently breaks fast-cancel and the gate stalls.pull-requests: writedrives the gate's owndequeuePullRequestGraphQL mutation (GitHub doesn't auto-remove UNMERGEABLE queue entries), and is also the cap for sonar's inheritedpull-requests: read.Neither can be scoped to a single job without adding per-job
permissionscaps to every leaf-call job on the merge gate — high risk for no real privilege gain. The in-file comment documents this, mirrored into the ignore justification.Verification
.github/zizmor.yml, withdocker-tags.ymlremoved (as .github: remove dead docker-tags workflow #22688 does):zizmor→ exit 0, "No findings to report" (17 ignored, 299 suppressed).docker-tagsfinding that .github: remove dead docker-tags workflow #22688 removes; the gate passes regardless (< 14).actionlintclean;make lint= 0 issues.Merge order
Pairs with #22688 (docker-tags removal). Either order is safe (the gate passes both ways); once both land,
excessive-permissionsreports zero findings and #21132 can close. The only remaining zizmor exceptions repo-wide are the deliberate policy ones (unpinned-uses,concurrency-limits) and the justified per-file ignores (cache-poisoning,secrets-inherit, and nowexcessive-permissions→ ci-gate).