cl/beacon/handler: reject a nil BlobsBundle instead of dereferencing it - #23586
Open
awskii wants to merge 2 commits into
Open
cl/beacon/handler: reject a nil BlobsBundle instead of dereferencing it#23586awskii wants to merge 2 commits into
awskii wants to merge 2 commits into
Conversation
…instead of dereferencing it
…not merely to fail differently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
produceBeaconBodyderefsbundlesatblock_production.go:1197with no nil check.getAssembledBlockFromResponseguards onlyExecutionPayloadand passesresp.BlobsBundlethrough, so an EL omittingblobsBundlearrives nil. The deref sits inside thewg.Goat:1144— unrecoverable, kills the process.Changes
bundles == nilbefore the version branch: error from Deneb, where the engine API makes the field mandatory; empty bundle before it, where it does not exist. At the consumer, so it covers everyExecutionEngine.Notes
Unguarded, the first test dies
SIGSEGVat:1197. Three mutations go red: remove the guard, drop the pre-Deneb fallback, invert the version test.Also on
release/3.6:1188andrelease/3.5:960.