p2p/discover: require bond for ping endpoint statements - #23609
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens discv4 endpoint prediction against unbonded PING statements.
Changes:
- Requires recent endpoint proof before accepting PING endpoint claims.
- Adds coverage for spoofed claims from multiple unbonded senders.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
p2p/discover/v4_udp.go |
Gates PING endpoint statements on bond status. |
p2p/discover/v4_udp_test.go |
Tests rejection of unbonded endpoint claims. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Send more than iptrackMinStatements so the unbonded test cannot pass vacuously if the predictor threshold changes, and give the bonded test a long PingInterval so table revalidation does not log after it returns.
AskAlexSharov
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An unbonded PING can no longer feed its claimed
Toaddress into the local endpoint predictor. Once a recent PONG proves return reachability, PING endpoint statements continue to work as before.Closes ethereum-bounty/erigon#31.