execution/engineapi: return INVALID for undecodable blockAccessList - #23633
Open
nerolation wants to merge 1 commit into
Open
execution/engineapi: return INVALID for undecodable blockAccessList#23633nerolation wants to merge 1 commit into
nerolation wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Returns an Engine API INVALID payload status when a block access list cannot be decoded.
Changes:
- Replace JSON-RPC invalid-params errors with
INVALIDpayload responses. - Update BAL tests for the revised behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
execution/engineapi/engine_server.go |
Returns INVALID with a validation error for undecodable BAL data. |
execution/engineapi/engine_api_bal_test.go |
Verifies malformed and semantically invalid BAL responses. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethereum/execution-apis#869