test(mapping): add dedicated tests for compose_mappings#12
Merged
Conversation
Cover gaps not exercised by the per-strategy test files: zero-strategy composition, single-strategy passthrough, all-miss path, three-strategy chain where the second fills and the third is not used, multiple events resolved by different strategies, duplicate-event deduplication, empty events, empty symbols, and result-key ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
compose_mappingsis the public API for stacking event-to-symbol strategies (regex, embedding, LLM, manual). It is mentioned explicitly in the roadmap and README as the composition primitive, but its behavior is only tested indirectly in two tests at the tail oftest_mapping_manual.py. This PR adds a dedicated test file covering the paths those tests miss.What
tests/test_mapping_compose.pywith 9 focused tests:Tests
tests/test_mapping_compose.py: 9 new tests, all greenSelf-merge gate
Generated by Claude Code