Skip to content

feat(tui): explain menu options on hover and with keyboard help - #29

Merged
errhythm merged 2 commits into
errhythm:mainfrom
GiorgoLazaridis:feat/tui-option-help
Oct 30, 2026
Merged

errhythm merged 2 commits into
errhythm:mainfrom
GiorgoLazaridis:feat/tui-option-help

Conversation

@GiorgoLazaridis

@GiorgoLazaridis GiorgoLazaridis commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The dashboard exposes policy controls such as gates, thresholds and consume-first without explaining what selecting them does. A user should be able to inspect an option before changing it.

Change

  • Use Textual's native hover tooltips for dashboard menu rows, including every Settings row and account-management submenus.
  • Add ? (shown in the footer) to open the same explanation for the highlighted row in the existing scrollable output modal. Esc closes help and preserves the selection.
  • Keep explanations separate from labels/action IDs, with one shared lookup for mouse and keyboard use. Tooltips use plain Rich Text, so help is not interpreted as markup.
  • Explain important differences: Auto opens in dry-run and needs confirmation to go live; consume-first can switch below the threshold; weekly inheritance can use weeklyThreshold; model gates are Claude-only; removing an account needs confirmation and deletes its saved backup.

Hovering or pressing ? does not dispatch the option, write settings, switch accounts, or touch credentials. No dependencies, new persistence or changelog.

Validation

  • GitHub CI: Linux, Windows and macOS checks passed at 848a4bf.
  • Full Linux/Python 3.13 suite: 4,606 passed, 13 skipped.
  • Pilot regression enables actual tooltips, hovers the label child, opens keyboard help, closes it, and verifies the threshold, selection and settings file stay unchanged. It also checks that every Settings row has help.
  • Independent read-only review found an inaccurate initial Auto explanation (the view starts in dry-run); that wording and the related gate/view/strategy descriptions were corrected against the existing implementation.
  • Whitespace and staged/history secret scans passed before push.

Tooltips require terminal mouse support. Keyboard help remains available without a mouse. This contribution is based directly on v0.43.0 and does not include the separate reset-display or language changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T21:23:19.620198Z
We couldn’t complete this review. Comment @codex review to try again.
848a4bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@errhythm
errhythm merged commit ff66e65 into errhythm:main Oct 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants