Repository navigation
Panel: finish the icon sweep in the computer switcher and session dialog - #252
Conversation
Three glyph spots were left when the interface emoji moved to inline SVG: the paired-computer switch buttons (overview and the Computers widget) still prefixed their label with the desktop-computer emoji, and the session details close button was a text X mark. All three now use the shared icon set — monitor for the switch buttons, x for close — so they draw the same on every WebView.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Thanks, @Seyamalam! Merged. The Computers widget test still expected the emoji, so I pushed a commit to your branch that checks for the icon instead. It's in the changelog for the next release. |
What changes for the user
Three glyph spots were left over from the emoji-to-SVG sweep: the paired-computer switch buttons (in the overview and in the Computers widget) still prefixed labels with the desktop-computer emoji, and the session details close button was a text X mark. On old WebViews those still render as whatever the years-old emoji font has. They now draw the same stroke icons as the rest of the panel.
How it works
monitoricon in the sharedICONSset (same Lucide stroke set as the rest of the panel chrome)..ov-pcswitch buttons now useicon('monitor', 'm')+ the computer name, identical to how the rules pause button was converted.icon('x'); itsaria-labelis unchanged.✳/◎), the charge-care⚡/🔋state and widget-content emoji stay as they are: content, not chrome.Checklist
PRIVACY.mdand can be turned off — none addedLan.csallow-list) or new ways to control the computer are explained above — none addedToPublic()and logs; processes start withArgumentList, no shell — unchangeddotnet test agent/PhoneBox.Agent.Tests,npx playwright test(intools/ui-tests),python tools/check-release.pyHow I tested it
The Computers widget spec now asserts the icons instead of the emoji text (same update pattern as the earlier sweep), and the session-sheet spec checks the close button icon.
npx playwright test: 241 passed.python tools/check-release.py: PASS.Summary by CodeRabbit