Skip to content

Panel: finish the icon sweep in the computer switcher and session dialog - #252

Merged
ersinkoc merged 2 commits into
ersinkoc:mainfrom
Seyamalam:fix/panel-chrome-icons-2
Nov 18, 2026
Merged

ersinkoc merged 2 commits into
ersinkoc:mainfrom
Seyamalam:fix/panel-chrome-icons-2

Conversation

@Seyamalam

@Seyamalam Seyamalam commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What changes for the user

Three glyph spots were left over from the emoji-to-SVG sweep: the paired-computer switch buttons (in the overview and in the Computers widget) still prefixed labels with the desktop-computer emoji, and the session details close button was a text X mark. On old WebViews those still render as whatever the years-old emoji font has. They now draw the same stroke icons as the rest of the panel.

How it works

  • New monitor icon in the shared ICONS set (same Lucide stroke set as the rest of the panel chrome).
  • The two .ov-pc switch buttons now use icon('monitor', 'm') + the computer name, identical to how the rules pause button was converted.
  • The session dialog close button uses icon('x'); its aria-label is unchanged.
  • Session brand marks (✳/◎), the charge-care ⚡/🔋 state and widget-content emoji stay as they are: content, not chrome.

Checklist

  • One change; unrelated changes are in their own pull request
  • New outbound connections have a row in PRIVACY.md and can be turned off — none added
  • New paths reachable over Wi-Fi (Lan.cs allow-list) or new ways to control the computer are explained above — none added
  • Secrets stay out of ToPublic() and logs; processes start with ArgumentList, no shell — unchanged
  • Tests: dotnet test agent/PhoneBox.Agent.Tests, npx playwright test (in tools/ui-tests), python tools/check-release.py

How I tested it

The Computers widget spec now asserts the icons instead of the emoji text (same update pattern as the earlier sweep), and the session-sheet spec checks the close button icon. npx playwright test: 241 passed. python tools/check-release.py: PASS.

Summary by CodeRabbit

  • Style
    • Computer-switching entries now use consistent icons instead of emoji prefixes, while preserving computer names, active states, and click behavior.
    • The session-details close button now uses an icon instead of a text character.
  • Tests
    • Integration checks now verify that computer-switching entries display icons and that the session-details close icon is visible.

Three glyph spots were left when the interface emoji moved to inline
SVG: the paired-computer switch buttons (overview and the Computers
widget) still prefixed their label with the desktop-computer emoji, and
the session details close button was a text X mark. All three now use
the shared icon set — monitor for the switch buttons, x for close — so
they draw the same on every WebView.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Computer-switch buttons now use shared SVG monitor icons instead of emoji. The session-details close button now uses a shared SVG close icon. Integration tests verify the icons and computer-name labels.

Changes: Shared icon updates

Layer / File(s) Summary
Monitor icons in computer-switch buttons
android/app/src/main/assets/www/main.js, android/app/src/main/assets/www/widgets/pc.js, tools/ui-tests/integration.spec.js
The icon map adds a monitor SVG path. Computer-switch buttons use the shared monitor icon and retain their names and active-state styling. The integration test checks for SVG icons and plain computer-name labels.
Session-details close icon
android/app/src/main/assets/www/widgets/basic.js, tools/ui-tests/integration.spec.js
The close button uses the shared close icon. The integration test checks that its SVG icon is visible.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: ersinkoc

Merge Risk: Minimal · up to c77db

This change swaps emoji and text marks for shared SVG icons in the computer switcher and the session dialog close button. The close button's aria-label is unchanged. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the two areas changed: the computer switcher buttons and the session dialog close control, both moved from emoji/text glyphs to shared SVG icons. It states the main change in one sente…
Description check Passed The description follows the repository template. It has the What changes for the user, How it works, Checklist, and How I tested it sections. The user-facing change is stated, the icon approach is exp…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two areas changed: the computer switcher buttons and the session dialog close control, both moved from emoji/text glyphs to shared SVG icons. It states the main change in one sentence and is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description follows the repository template. It has the What changes for the user, How it works, Checklist, and How I tested it sections. The user-facing change is stated, the icon approach is explained, and the checklist is filled in. Testing gives the Playwright result (241 passed) and the check-release result. The dotnet test command is listed in the checklist but no outcome is reported. The description does not link an issue with 'Fixes #123', and the template asks for that link.

Resolution

Optional: add an issue link (for example 'Fixes #N') under What changes for the user if one exists. State the outcome of dotnet test agent/PhoneBox.Agent.Tests in How I tested it, or note that it was not run.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between da902ca and c77db92.

Files selected for processing: 1

  • tools/ui-tests/integration.spec.js

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@ersinkoc
ersinkoc merged commit d4cb151 into ersinkoc:main Nov 18, 2026
9 checks passed
@ersinkoc

Copy link
Copy Markdown
Owner

Thanks, @Seyamalam! Merged. The Computers widget test still expected the emoji, so I pushed a commit to your branch that checks for the icon instead. It's in the changelog for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants