build(deps): update cargo-rail to 0.29.0 - #463
Open
loadingalias wants to merge 1 commit into
Open
loadingalias wants to merge 1 commit into
loadingalias wants to merge 1 commit into
Conversation
Collaborator
|
Hey @loadingalias! It looks like my renovate cronjob auto-approved and merged the renovate PR doing the same thing, I appreciate you reaching out and updating the config though, would happily merge that if you could fix the conflicts. The main reasons I switched to cargo-rail were documented in the doc/plan in this PR: unifying dependencies, pruning dead features, detecting unused dependencies, and computing the MSRV. So far it's been working pretty well as far as I can tell. I haven't noticed anything wrong, and generally if something is quietly working then I'm happy! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
affectedtask and stale implementation planValidation
cargo rail config validate --strictcargo rail config explain --all -f jsonmise run unify-check— dependencies are coherentFeedback
Cargo-Rail reports the workspace deps are coherent while preserving the
eryx-wasm-runtimeanderyx-macrosexclusions.I am really just submitting the PR to help update Cargo-Rail and to understand your usage. I wanted to ask for direct feedback, as well. What isn't Cargo-Rail doing well that you'd expected? What do you like or dislike? What's not working as you'd expected or what have you found that's not correct?
I genuinely appreciate the feedback! I was also thinking... for a follow up Cargo-Rail-Action migration, which CI decisions would you want Cargo-Rail to own? Let me know! Feel free to reach out or open issues, discussions, etc.