Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the section Networking of the pineapple application is possible connect the interface wlan1 to a wifi but this method only works with WPA encryption, using WEP protocol simply doesn't connect.
This happens because the api of the module 'networking' (/pineapple/modules/Networking/api/module.php), in the function connectToAP(), is only designed to modify the wireless configuration file (/etc/config/wireless) in the case that the encryption be open or differents types of WPA.
This is not exactly a bug, simply the function wasn't designed to all cases but I think that is really interesting at least have the WEP protocol because is unusual but unfortunately is used and is a weakness that in a pentest can be used to provide internet to our device.
To fix this issue I modified the file '/pineapple/modules/Networking/api/module.php' adding to the switch the case of WEP protocol, because it's neccessary modify the variable of configuration 'encrypt', in this case is ' web', and the key should be the hexdump of the string. The changes done can see it in the next images: https://ibb.co/dkKeXQ || https://ibb.co/cjMF6k