docs: setup firebase hosting con github actions#3
Merged
Conversation
Review Summary by QodoConfigure GitHub Actions for Firebase Hosting deployment
WalkthroughsDescription• Configure GitHub Actions workflows for Firebase Hosting deployment • Add automatic deployment on merge to main branch • Add preview deployment on pull requests • Update Firebase project ID to finanz-services Diagramflowchart LR
A["GitHub Push to main"] -- "triggers" --> B["firebase-hosting-merge.yml"]
B -- "builds & deploys" --> C["Firebase Hosting Live"]
D["GitHub Pull Request"] -- "triggers" --> E["firebase-hosting-pull-request.yml"]
E -- "builds & previews" --> F["Firebase Hosting Preview"]
G[".firebaserc"] -- "updated project ID" --> H["finanz-services"]
File Changes1. .firebaserc
|
Code Review by Qodo
1. Deploys placeholder site
|
|
Visit the preview URL for this PR (updated for commit d905bd4): https://finanz-services--pr3-feat-github-workflow-3m2lwuak.web.app (expires Tue, 17 Mar 2026 18:47:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4905a912ab243faab8eac1b38a9b8711115b94d9 |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+14
to
+20
| - run: npm ci && npm run build | ||
| - uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| repoToken: ${{ secrets.GITHUB_TOKEN }} | ||
| firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FINANZ_SERVICES }} | ||
| channelId: live | ||
| projectId: finanz-services |
There was a problem hiding this comment.
1. Deploys placeholder site 🐞 Bug ✓ Correctness
The new workflows run npm run build but Firebase Hosting is configured to serve the checked-in public/ directory, so the deployment can publish the default Firebase placeholder page instead of the app. This will make production deploys incorrect even though CI reports a successful build/deploy.
Agent Prompt
## Issue description
GitHub Actions runs `npm run build`, but Firebase Hosting is configured to serve `public/`, which currently contains the default Firebase Hosting placeholder page. This means deployments can publish the placeholder instead of the built app.
## Issue Context
- `firebase.json` serves `public/` and rewrites all routes to `/index.html`.
- `public/index.html` is the Firebase Hosting welcome page.
- Build script is `vite build` and there is no Vite config shown to emit output into `public/`.
## Fix Focus Areas
- firebase.json[1-16]
- package.json[6-16]
- vite.config.ts[1-30]
- .github/workflows/firebase-hosting-merge.yml[13-20]
- .github/workflows/firebase-hosting-pull-request.yml[15-21]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios realizados:
firebase-hosting-merge.ymlyfirebase-hosting-pull-request.yml.finanz-servicesde Firebase.Validación: