Conversation
docs: setup firebase hosting con github actions
Review Summary by QodoConfigure Firebase Hosting with GitHub Actions workflows
WalkthroughsDescription• Configure Firebase Hosting deployment with GitHub Actions • Add automated CI/CD workflows for merge and pull request events • Update Firebase project configuration to finanz-services • Enable automatic builds and deployments on main branch Diagramflowchart LR
A["GitHub Repository"] -- "Push to main" --> B["firebase-hosting-merge.yml"]
A -- "Pull Request" --> C["firebase-hosting-pull-request.yml"]
B -- "Build & Deploy" --> D["Firebase Hosting<br/>finanz-services"]
C -- "Build & Preview" --> D
File Changes1. .firebaserc
|
Code Review by Qodo
1. Deploys placeholder site
|
|
Visit the preview URL for this PR (updated for commit 55884c6): https://finanz-services--pr4-develop-vxcmm2ng.web.app (expires Tue, 17 Mar 2026 18:55:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4905a912ab243faab8eac1b38a9b8711115b94d9 |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+14
to
+20
| - run: npm ci && npm run build | ||
| - uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| repoToken: ${{ secrets.GITHUB_TOKEN }} | ||
| firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_FINANZ_SERVICES }} | ||
| channelId: live | ||
| projectId: finanz-services |
There was a problem hiding this comment.
1. Deploys placeholder site 🐞 Bug ✓ Correctness
The new deploy workflows run npm run build, but Firebase Hosting is configured to deploy the public/ directory, which contains the default Firebase placeholder public/index.html rather than the Vite build output. This will publish the placeholder page (or otherwise miss built assets) on PR previews and live deploys.
Agent Prompt
### Issue description
CI builds the Vite app (`npm run build`) but Firebase Hosting deploys the `public/` directory, which currently contains the Firebase default placeholder page. This causes preview/live deploys to not serve the built app.
### Issue Context
- Vite build is invoked in both workflows.
- Firebase Hosting deploy source is controlled by `firebase.json` (`hosting.public`).
### Fix Focus Areas
- firebase.json[1-16]
- .github/workflows/firebase-hosting-merge.yml[13-20]
- .github/workflows/firebase-hosting-pull-request.yml[15-21]
- public/index.html[1-20]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios realizados:
firebase-hosting-merge.ymlyfirebase-hosting-pull-request.yml.finanz-servicesde Firebase.Validación: