Support string based properties#7
Open
pmccarren wants to merge 7 commits into
Open
Conversation
This allows string based keys, such as uuids, to remain intact.
This allows string based keys, such as uuids, to remain intact. Closes esbenp#6
Author
|
Just a friendly heads up: the Travis HHVM build failed because of this:
|
- Use Ubuntu Trusty instead of Ubuntu Precise. - Add PHP 7.1 build Closes esbenp#8
|
Can we have a tagged release of this? |
Author
|
If of interest, I created ventepos/architect@1.1.0 |
|
+1, I've been using this in production builds and hasn't failed me once (yet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows string based IDs, such as UUIDs, behave correctly.
Closes #6