Skip to content

Fix radioelement scrolling #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matan23 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix radioelement scrolling #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0122de0
Updated pod
escoz Aug 25, 2015
1558f18
radioelement - scroll to preselected element only after the view did …
matan23 Nov 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion QuickDialog.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'QuickDialog'
s.version = '1.0.2'
s.version = '1.1.0'
s.platform = :ios, '5.0'
s.license = 'Apache License, Version 2.0'
s.summary = 'Quick and easy dialog screens for iOS.'
Expand All @@ -25,5 +25,25 @@ Pod::Spec.new do |s|
sp.source_files = 'extras', '*.{h,m}'
end

s.subspec "QPicker" do |sp|
sp.dependency 'QuickDialog/Core'
sp.source_files = 'extras/QPicker*.{h,m}'
end
s.subspec "QMail" do |sp|
sp.dependency 'QuickDialog/Core'
sp.source_files = 'extras/QMail*.{h,m}'
end
s.subspec "QMap" do |sp|
sp.dependency 'QuickDialog/Core'
sp.source_files = 'extras/QMap*.{h,m}'
end
s.subspec "QWeb" do |sp|
sp.dependency 'QuickDialog/Core'
sp.source_files = 'extras/QWeb*.{h,m}'
end
s.subspec "QColor" do |sp|
sp.dependency 'QuickDialog/Core'
sp.source_files = 'extras/QColor*.{h,m}', 'extras/UIColor*.{h,m}'
end

end
6 changes: 3 additions & 3 deletions quickdialog/QuickDialogController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,15 @@ - (void)viewWillAppear:(BOOL)animated {
if (_root!=nil) {
self.title = _root.title;
self.navigationItem.title = _root.title;
if (_root.preselectedElementIndex !=nil)
[self.quickDialogTableView scrollToRowAtIndexPath:_root.preselectedElementIndex atScrollPosition:UITableViewScrollPositionTop animated:NO];

}
}

- (void)viewDidAppear:(BOOL)animated {
[super viewDidAppear:animated];

if (_root!=nil && _root.preselectedElementIndex !=nil) {
[self.quickDialogTableView scrollToRowAtIndexPath:_root.preselectedElementIndex atScrollPosition:UITableViewScrollPositionTop animated:NO];
}
if (_root.showKeyboardOnAppear) {
QEntryElement *elementToFocus = [_root findElementToFocusOnAfter:nil];
if (elementToFocus!=nil) {
Expand Down