fix: plan panel squeezing layout + storm breaker deadlock#2346
Open
dengmik-commits wants to merge 1 commit into
Open
fix: plan panel squeezing layout + storm breaker deadlock#2346dengmik-commits wants to merge 1 commit into
dengmik-commits wants to merge 1 commit into
Conversation
…lock (esengine#2345) - Remove execution-phase condition from planPanelOpen so the conversation area returns to full width after accepting a plan. - Reorder allSuppressed check above steerQueue in repair path to prevent infinite loop when storm breaker suppresses all tool calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bug fixes:
1. Plan panel squeezing the conversation area (fixes #2338)
After accepting a plan, the right-side panel stayed open during execution, keeping the conversation area at 35% width. This was caused by the
planPanelOpencondition including(planStepsRef.current && planStepsRef.current.length > 0 && !planMode), which kept the panel open for the entire execution phase.Fix: Removed that condition. The panel now only opens for interactive states (pendingPlan, stagedInput, checkpoint, revision, reviseEditor). During execution, plan progress is shown inline via the existing
PlanLiveRowcomponent.2. Storm breaker deadlock (fixes #2345)
When the model kept calling the same tool with identical arguments, the storm breaker correctly suppressed the calls. However, after the self-correction attempt failed and the "stuck retry loop" warning was emitted, if
_steerQueuehad any messages, the code wouldcontinuethe loop without resetting the storm breaker state—causing an infinite loop where every subsequent attempt was immediately suppressed again.Fix: Moved the
allSuppressedcheck above thesteerQueuecheck. When all tool calls are suppressed and self-correction has failed, the turn now always terminates viaforceSummaryAfterIterLimit, regardless of steer queue contents.Changes
src/cli/ui/App.tsx: Remove execution-phase condition fromplanPanelOpensrc/loop.ts: ReorderallSuppressed/steerQueuechecks in repair path