Skip to content

Temporary PR Combo Beta with Windows Installer / 临时组合内测与 Windows 安装包#2349

Open
SivanCola wants to merge 15 commits into
esengine:v1from
SivanCola:codex/pr-combo-win-package
Open

Temporary PR Combo Beta with Windows Installer / 临时组合内测与 Windows 安装包#2349
SivanCola wants to merge 15 commits into
esengine:v1from
SivanCola:codex/pr-combo-win-package

Conversation

@SivanCola
Copy link
Copy Markdown
Contributor

Summary

This PR prepares a temporary combined beta build for internal testing. It includes the current PR-combo changes from:

It also adds a temporary Windows-only packaging path so testers can use a Windows installer immediately. For this internal test round, the Windows .exe installer is recommended.

Published Windows beta release:
https://github.com/SivanCola/DeepSeek-Reasonix/releases/tag/desktop-v0.52.3

Recommended artifact:

  • Reasonix_0.52.3_x64-setup.exe
    • SHA256: 8a49df738d3c0c035597b4ab9be4261d627509b623dc5c7893aa3d87ccd7f389

Alternative artifact:

  • Reasonix_0.52.3_x64_en-US.msi
    • SHA256: 150979958b83cd2951bd37d8ccf04fa49eb789a77de560388a7506ca3217ae32

Root Cause

The normal desktop release workflow is cross-platform and also expects updater signing material when updater artifacts are enabled. For an unsigned Windows beta package, Tauri successfully generated the Windows .msi and .exe, but the job failed after bundling because updater artifact signing tried to run without TAURI_SIGNING_PRIVATE_KEY.

Technical Approach

The temporary packaging workflow narrows this beta path to Windows x64, disables updater artifact generation for the unsigned test build, runs tauri build directly, and uploads the generated .exe and .msi both as GitHub Actions artifacts and GitHub Release assets.

Focused Optimization Points

  • Preserve the PR-combo behavior exactly for internal testing.
  • Keep the Windows beta package unblocked by unrelated Linux/macOS packaging issues.
  • Avoid passing empty signing secrets into Tauri for unsigned test builds.
  • Disable updater artifacts only for this temporary unsigned Windows beta path.
  • Provide both NSIS .exe and MSI installers; recommend .exe for ordinary testers.

Verification

  • Local npm run build: passed.
  • Local npm run cache:guard: PASS.
  • Local focused regression suite: 181 tests passed.
  • Local npm run verify: passed during push of codex/pr-combo-mac-beta.
  • GitHub Actions run 26675041303: passed on codex/pr-combo-win-package.
  • Release desktop-v0.52.3: published as prerelease with Windows x64 assets.

中文说明

这个 PR 用于准备一版临时组合内测包,包含以下 PR 的当前合并结果:

同时加入一个临时 Windows-only 打包路径,用于快速解决 Windows 内测分发问题。本轮内测建议 Windows 用户优先使用 .exe 安装包。

Windows 内测包发布地址:
https://github.com/SivanCola/DeepSeek-Reasonix/releases/tag/desktop-v0.52.3

建议使用:

  • Reasonix_0.52.3_x64-setup.exe
    • SHA256: 8a49df738d3c0c035597b4ab9be4261d627509b623dc5c7893aa3d87ccd7f389

备用:

  • Reasonix_0.52.3_x64_en-US.msi
    • SHA256: 150979958b83cd2951bd37d8ccf04fa49eb789a77de560388a7506ca3217ae32

问题原因

常规 desktop release workflow 是跨平台矩阵,并且在开启 updater artifacts 时会要求 updater 签名密钥。对于本次 unsigned Windows 内测包,Tauri 已经成功生成 .msi.exe,但后续 updater artifact 签名阶段因为没有 TAURI_SIGNING_PRIVATE_KEY 而失败。

技术方案

临时 packaging workflow 将本次 beta 路径收敛为 Windows x64,在 unsigned 测试构建中关闭 updater artifact 生成,直接运行 tauri build,并把生成的 .exe.msi 同时上传为 GitHub Actions artifact 与 GitHub Release asset。

本次集中优化点

  • 保留 PR-combo 行为,用于内测验证。
  • Windows 内测包不再被 Linux/macOS packaging 问题阻塞。
  • unsigned 测试构建不再向 Tauri 传入空签名 secret。
  • 仅在临时 unsigned Windows beta 路径关闭 updater artifacts。
  • 同时提供 NSIS .exe 和 MSI;普通内测用户建议优先使用 .exe

验证

  • 本地 npm run build:通过。
  • 本地 npm run cache:guard:PASS。
  • 本地 focused regression suite:181 tests passed。
  • 本地 npm run verify:推送 codex/pr-combo-mac-beta 时通过。
  • GitHub Actions run 26675041303:在 codex/pr-combo-win-package 通过。
  • desktop-v0.52.3 prerelease:已发布并包含 Windows x64 安装包。

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ebd147f55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/ui/composer.tsx Outdated
@esengine esengine added the v1 Legacy TypeScript line (0.x) — v1 branch, maintenance only label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 Legacy TypeScript line (0.x) — v1 branch, maintenance only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants