fix(cli): auto-scroll to bottom on turn end (#2378)#2383
Open
GoggleHe wants to merge 2 commits into
Open
Conversation
When the user scrolls up during a streaming turn, the chat-scroll-store sets pinned=false and the viewport stays at the user's position. On turn end, nothing re-pinned the viewport, so the user had to manually scroll down or press End to see the final answer. Add chatScroll.jumpToBottom() after setBusy(false) in the main turn execution path so the viewport always settles on the final output.
GoggleHe
force-pushed
the
fix/cli-auto-scroll-on-turn-end
branch
from
a8144ca to
fa33d16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the user scrolls up during a streaming turn, the chat-scroll-store sets
pinned=falseand the viewport stays at the user's position. On turn end, nothing re-pinned the viewport, so the user had to manually scroll down or press End to see the final answer.This PR adds
chatScroll.jumpToBottom()aftersetBusy(false)in the main turn execution path so the viewport always settles on the final output.Root Cause
Reasonix has two scroll implementations:
useAutoScroll.ts)chat-scroll-store.ts)pinnedstayedfalseThe desktop version already handles this correctly (fixed in #1182). This PR brings the CLI version to parity.
Change
1 file, +3 lines —
src/cli/ui/App.tsxRelated