fix(tui): render ask_choice custom input inline#2394
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0ebf50562
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
XTLine
force-pushed
the
fix/choice-custom-inline-input
branch
from
d0ebf50 to
e0602d4
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0602d49fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
XTLine
force-pushed
the
fix/choice-custom-inline-input
branch
from
e0602d4 to
e8a5a01
Compare
2 participants
What
Render the
ask_choicecustom answer path directly in the terminal TUI picker whenallowCustomis true.The picker now includes a selectable custom-answer row and an inline text input. Pressing Enter still submits the currently highlighted row, so typed custom text is only used when the custom row is selected.
Why
Fixes #2382. The protocol already carried
allowCustom, but the terminal TUI did not expose the custom-answer path in the picker flow.How to verify
npm test -- tests/choice-confirm-render.test.tsx tests/choice.test.ts tests/pause-gate.test.tsnpm run typechecknpm run lintnpm run verifyChecklist
npm run verifypasses locally (lint + typecheck + tests + comment-policy gate)Co-Authored-By: Claudetrailer in commitsCHANGELOG.md— release notes are maintainer-written at release time