Skip to content

🧹 refactor: simplify _platformConfiguration by extracting platform properties #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esenmx merged 1 commit into from
Jul 16, 2026
Merged

🧹 refactor: simplify _platformConfiguration by extracting platform properties #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 43 additions & 17 deletions lib/src/mk_map_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,22 +283,10 @@ final class _MKMapViewState extends State<MKMapView>
final (
PlatformMapKind kind,
MKMapEmphasisStyle emphasisStyle,
showsTraffic,
pointOfInterestFilter,
) = switch (widget.preferredConfiguration) {
MKStandardMapConfiguration(
:final emphasisStyle,
:final showsTraffic,
:final pointOfInterestFilter,
) =>
(.standard, emphasisStyle, showsTraffic, pointOfInterestFilter),
MKHybridMapConfiguration(
:final showsTraffic,
:final pointOfInterestFilter,
) =>
(.hybrid, .standard, showsTraffic, pointOfInterestFilter),
MKImageryMapConfiguration() => (.imagery, .standard, false, null),
};
bool showsTraffic,
PlatformPointOfInterestFilter? pointOfInterestFilter,
) = widget.preferredConfiguration._platformProperties;

return PlatformMapConfiguration(
kind: kind,
emphasisStyle: emphasisStyle,
Expand All @@ -315,7 +303,7 @@ final class _MKMapViewState extends State<MKMapView>
isZoomEnabled: widget.isZoomEnabled,
isPitchEnabled: widget.isPitchEnabled,
selectableMapFeatures: widget.selectableMapFeatures.toList(),
pointOfInterestFilter: pointOfInterestFilter?.toPlatform(),
pointOfInterestFilter: pointOfInterestFilter,
cameraZoomRange: widget.cameraZoomRange.toPlatform(),
cameraBoundary: widget.cameraBoundary?.toPlatform(),
);
Expand Down Expand Up @@ -449,3 +437,41 @@ final class _MKMapViewState extends State<MKMapView>
void onDidFailToLocateUser(String error) =>
widget.onDidFailToLocateUser?.call(error);
}

extension on MKMapConfiguration {
(
PlatformMapKind,
MKMapEmphasisStyle,
bool,
PlatformPointOfInterestFilter?,
)
get _platformProperties => switch (this) {
MKStandardMapConfiguration(
:final emphasisStyle,
:final showsTraffic,
:final pointOfInterestFilter,
) =>
(
PlatformMapKind.standard,
emphasisStyle,
showsTraffic,
pointOfInterestFilter.toPlatform(),
),
MKHybridMapConfiguration(
:final showsTraffic,
:final pointOfInterestFilter,
) =>
(
PlatformMapKind.hybrid,
MKMapEmphasisStyle.standard,
showsTraffic,
pointOfInterestFilter.toPlatform(),
),
MKImageryMapConfiguration() => (
PlatformMapKind.imagery,
MKMapEmphasisStyle.standard,
false,
null,
),
};
}
Loading