Skip to content

⚡ Optimize overlay updates with batched removal #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esenmx merged 1 commit into from
Aug 10, 2026
Merged

⚡ Optimize overlay updates with batched removal #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions darwin/mapkit_flutter/Sources/mapkit_flutter/MapView/MapKitViewHost.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,23 @@ public class MapKitViewHost: NSObject, @preconcurrency MapKitHostApi {
}

private func applyOverlayUpdate(adding: [any FlutterOverlay], changing: [any FlutterOverlay], removing: [String]) {
var overlaysToRemove: [MKOverlay] = []
for id in removing {
if let overlay = self.overlaysById.removeValue(forKey: id) {
self.mapView.removeOverlay(overlay)
overlaysToRemove.append(overlay)
}
}
for new in changing {
if let old = self.overlaysById[new.id] {
self.mapView.removeOverlay(old)
overlaysToRemove.append(old)
}
}

if !overlaysToRemove.isEmpty {
self.mapView.removeOverlays(overlaysToRemove)
}

for new in changing {
self.addOverlay(new)
}
for new in adding {
Expand Down
Loading