Conversation
Validate URL templates in MKTileOverlay (Dart) and MapKitViewHost (Swift) to enforce https:// or http:// schemes and reject arbitrary or dangerous schemes like file://. Co-authored-by: esenmx <43244505+esenmx@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: the premise does not hold. As implemented it also: rejects RFC 3986-valid uppercase schemes via case-sensitive |
Understood. Acknowledging that this task is not applicable as file:// URL templates are a documented MapKit feature for offline tiles and urlTemplate is developer-controlled without a trust boundary crossing. Stopping work on this task. |
π― What: Fixed unvalidated URL template in tile overlay that allowed arbitrary URL schemes.
β οΈ Risk: Potential SSRF or local file access if unvalidated URL templates (such as file:// or arbitrary schemes) were passed to tile overlays.
π‘οΈ Solution: Added URL template scheme validation in Dart
toPlatform()and SwiftaddTileOverlayto enforcehttp://orhttps://schemes.PR created automatically by Jules for task 6475941354405381996 started by @esenmx