Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-locate annotation drag delegate callback in AnnotationController.swift with other annotation delegate methods and break down drag handling into dedicated helper functions. Co-authored-by: esenmx <43244505+esenmx@users.noreply.github.com>
…oller Drop the handleAnnotationDragChange/handleAnnotationDragEnd helper split so the relocation reads as a pure move (+21/-21, added block byte-identical to the removed one). Keeps `annotation.wasDragged = true` ordered before onAnnotationDragEnd, which annotationsToChange relies on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b6e4e62 to
75f6dd4
Compare
🎯 What
Refactored
mapView(_:annotationView:didChange:fromOldState:)by moving it toAnnotationController.swiftalongside other annotation delegate methods and breaking down the drag lifecycle logic into smaller helper functions (handleAnnotationDragChange,handleAnnotationDragEnd).💡 Why
AnnotationController.swift.✅ Verification
flutter test(all 144 unit tests passed).flutter analyzeanddart format(0 issues found).#Correct#).✨ Result
Cleaner, modular, and more maintainable Swift codebase for annotation drag lifecycle handling without changing any external behavior.
PR created automatically by Jules for task 1535924952615495644 started by @esenmx