Skip to content

Create requirements.txt#46

Open
demitri wants to merge 2 commits into
esheldon:masterfrom
demitri:master
Open

Create requirements.txt#46
demitri wants to merge 2 commits into
esheldon:masterfrom
demitri:master

Conversation

@demitri

@demitri demitri commented Apr 1, 2020

Copy link
Copy Markdown

Adding a requirements.txt file to help determine package dependencies.

@beckermr beckermr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be missing joblib here. I need to double check.

Adding missing `joblib` package.
@demitri

demitri commented Apr 2, 2020

Copy link
Copy Markdown
Author

Good catch; updated.

@beckermr

beckermr commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

@esheldon anything to add here?

@beckermr

beckermr commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

Is esutil used?

@esheldon

Copy link
Copy Markdown
Owner

is this ready?

@beckermr

Copy link
Copy Markdown
Collaborator

I asked about esutil. Maybe we should compare to the conda package?

@esheldon

Copy link
Copy Markdown
Owner

@esheldon

Copy link
Copy Markdown
Owner

that only lists

    - numpy
    - fitsio
    - pyyaml
    - esutil

is that incomplete?

@esheldon

Copy link
Copy Markdown
Owner

and I don't even see yaml used in the meds repo

@beckermr

Copy link
Copy Markdown
Collaborator

it probably is incomplete

@esheldon

Copy link
Copy Markdown
Owner

OK. I'm working on some unit tests today. I'll add a requirements that is correct as well. We can update the meds feedstock based on that.

@esheldon

Copy link
Copy Markdown
Owner

I added a requirements.txt in this PR #51

@esheldon

Copy link
Copy Markdown
Owner

biggles is no longer supported, planning to move the meds-view code to matplotlib at some point

@esheldon

Copy link
Copy Markdown
Owner

I merged #51 which added a requirements.txt

It only has the things needed for the current tests. We will need more things once the other codes are rewritten, e.g. the meds viewer code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants