Repository navigation
Move the hexos-test harness apps to v6 with their actions and widgets - #65
Merged
Merged
Conversation
hexos-test, hexos-test-fail and hexos-test-inline move to the v6 install script format, copied unchanged from feature/app-actions-widgets. hexos-test gains the harness actions and widgets the app surface E2E specs run. Lifecycle hooks parse to the same runnable hooks as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hexos-test, hexos-test-fail and hexos-test-inline move to the v6 install script format, and hexos-test gains the harness actions and widgets that hexos-platform's app surface E2E specs (19-app-surfaces/2 and 3) need. The v6 versions only existed on feature/app-actions-widgets (#38), which isn't ready to merge, so every catalog sync put the v5 hexos-test back on dev main.
The three files are copied unchanged from #38's branch, and nothing else from #38 comes with them. The hook scripts they call (
hexos-test/hooks.ts,hexos-test-fail/hooks.ts) are already on staging and identical on both branches, so #38 will still merge cleanly on these files.What changes:
events,title,optionalon the hook). Run through platform staging'srunnableHooksFromScript, every lifecycle hook in all three apps matches its v5 version: same ids, events, entry points, optional flags, timeouts, retries and upgrade range, and the same install consent row.All three apps are
customandinternal, and this PR targets staging only.Testing:
bun _lib/validate.ts: 52 install scripts, 0 errors_libtypecheck passesparseAppHooksV6) reports no errors for any of the three, and the v5 and v6 runnable hooks match field by field