Refactor 'NumKeypad' module to match tab name 'Record'#164
Open
tjsr wants to merge 1 commit into
Open
Conversation
Author
|
I would also suggest that all of the page tab classes be renamed to *Page. This gives them a consistent name and makes it clear their intended usage within the application as a UI view, rather than either an individual control or controller class/module. |
…y with other pages.
tjsr
force-pushed
the
develop/refactor/record
branch
from
February 25, 2025 02:48
cc55bb7 to
b58d865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with other pages, I have refactored the NumKeypad.py module to 'Record.py', and split out the relevant code so that only the Keypad related code now exists in its own module.
I'd like to have this implemented so that I can start doing more major work to these components including: