Fix warnings in restricted environments#466
Open
mroi wants to merge 2 commits into
Open
Conversation
• do not access index.html/* when checking file existence • do not try to mkdir() above PATH_ROOT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably a controversial pull request, but I decided to suggest it anyways. I am developing an esoTalk forum app for Nextcloud over here. (*)
Unfortunately, Nextcloud runs PHP with strict error reporting and I additionally add
open_basedirrestrictions on top. The first patch in this pull request fixes many warnings esoTalk emits with PHP strict reporting. The second patch fixes warnings due toopen_basedir. These should have no particular effect on standard esoTalk installations, since I (hopefully) did not change any code semantics.The only limitation I can see is that the array indexing for function returns only works with PHP 5.4 and above. So feel free to reject this pull request or cherry-pick from it. Or ask me questions for particular changes.
(*) I know that I will have to transition to Flarum in the near future, but I am maintaining this anyways, because it is in active use for a project I manage.