Skip to content

[lvgl] Add note emphasising display validation#6702

Merged
clydebarrow merged 1 commit into
currentfrom
clydebarrow-patch-3
May 30, 2026
Merged

[lvgl] Add note emphasising display validation#6702
clydebarrow merged 1 commit into
currentfrom
clydebarrow-patch-3

Conversation

@clydebarrow
Copy link
Copy Markdown
Contributor

Description

Related issue (if applicable): fixes esphome/esphome#16671

Pull request in esphome with YAML changes (if applicable):

  • esphome/esphome#

Checklist

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /src/content/docs/components/index.mdx when creating new documents for new components or cookbook.

New Component Images

If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.

To generate a component image:

  1. Comment on this pull request with the following command, replacing component_name with your component name in lower_case format with underscores (e.g., bme280, sht3x, dallas_temp):

    @esphomebot generate image component_name
    
  2. The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.

  3. Extract the SVG file and place it in the /public/images/ folder of this repository.

  4. Use the image in your component's index table entry in /src/content/docs/components/index.mdx.

Example: For a component called "DHT22 Temperature Sensor", use:

@esphomebot generate image dht22

Note: All images used in ImgTable components must be placed in /public/images/ as the component resolves them to absolute paths.

Copilot AI review requested due to automatic review settings May 27, 2026 08:27
@clydebarrow clydebarrow changed the title [current] Add note emphasising display validation [lvgl] Add note emphasising display validation May 27, 2026
@esphome esphome Bot added the current label May 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a prominent warning in the LVGL component docs to encourage users to validate their display/LVGL setup (especially color correctness) using the provided “hello world” example before building more complex UI content.

Changes:

  • Inserted a GitHub-flavored [!NOTE] alert in the LVGL “TL;DR” section.
  • Emphasized verifying display color output against the example image before proceeding with custom content.

Comment on lines +34 to +37
> [!NOTE]
> It is strongly recommended that you verify correct display and LVGL configuration on a new device by using this example
> *before* attempting to add your own content. Check that the display colors match the example image (layout will vary
> depending on display dimensions.)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am biased, but I personally prefer the original wording to the suggestion by copilot 🤷‍♂️

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit b2802b4
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/6a16aadabce82a0008bcfd7d
😎 Deploy Preview https://deploy-preview-6702--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e2c40383-a45a-46d0-914e-c76a07de0e00

📥 Commits

Reviewing files that changed from the base of the PR and between d61b3fe and b2802b4.

📒 Files selected for processing (1)
  • src/content/docs/components/lvgl/index.mdx

Walkthrough

A single admonition note was added to the LVGL component documentation under the "TL;DR" section, providing guidance for users to verify correct display and LVGL configuration using the provided example before adding custom content, with a reminder to check color accuracy while accounting for layout differences across display sizes.

Changes

LVGL Documentation Verification Guidance

Layer / File(s) Summary
TL;DR verification guidance note
src/content/docs/components/lvgl/index.mdx
A [!NOTE] admonition inserted under the TL;DR section recommends users verify display and LVGL configuration using the example first, and confirms that display colors match the example image while noting layout may vary by display dimensions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR addresses issue #16671 by adding a validation note, but the issue requests a technical fix for JPEG color corruption on ESP32-P4, not documentation guidance. The documentation note about display validation does not address the core technical issue of JPEG color corruption. Implement the requested technical fix for the online_image decode path on ESP32-P4.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title '[lvgl] Add note emphasising display validation' accurately describes the main change—adding a documentation note about display validation to the LVGL component index.
Description check ✅ Passed The description is related to the changeset, referencing issue #16671 and indicating this is a documentation fix merged into the current branch.
Out of Scope Changes check ✅ Passed All changes are in-scope—the PR adds a documentation note to the LVGL component index as intended.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch clydebarrow-patch-3

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@guillempages guillempages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +34 to +37
> [!NOTE]
> It is strongly recommended that you verify correct display and LVGL configuration on a new device by using this example
> *before* attempting to add your own content. Check that the display colors match the example image (layout will vary
> depending on display dimensions.)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am biased, but I personally prefer the original wording to the suggestion by copilot 🤷‍♂️

@clydebarrow clydebarrow merged commit 274b528 into current May 30, 2026
14 of 16 checks passed
@clydebarrow clydebarrow deleted the clydebarrow-patch-3 branch May 30, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[online_image] JPEG colour corruption on ESP32-P4 MIPI DSI with LVGL

3 participants