[lvgl] Add note emphasising display validation#6702
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a prominent warning in the LVGL component docs to encourage users to validate their display/LVGL setup (especially color correctness) using the provided “hello world” example before building more complex UI content.
Changes:
- Inserted a GitHub-flavored
[!NOTE]alert in the LVGL “TL;DR” section. - Emphasized verifying display color output against the example image before proceeding with custom content.
| > [!NOTE] | ||
| > It is strongly recommended that you verify correct display and LVGL configuration on a new device by using this example | ||
| > *before* attempting to add your own content. Check that the display colors match the example image (layout will vary | ||
| > depending on display dimensions.) |
There was a problem hiding this comment.
Maybe I am biased, but I personally prefer the original wording to the suggestion by copilot 🤷♂️
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single admonition note was added to the LVGL component documentation under the "TL;DR" section, providing guidance for users to verify correct display and LVGL configuration using the provided example before adding custom content, with a reminder to check color accuracy while accounting for layout differences across display sizes. ChangesLVGL Documentation Verification Guidance
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| > [!NOTE] | ||
| > It is strongly recommended that you verify correct display and LVGL configuration on a new device by using this example | ||
| > *before* attempting to add your own content. Check that the display colors match the example image (layout will vary | ||
| > depending on display dimensions.) |
There was a problem hiding this comment.
Maybe I am biased, but I personally prefer the original wording to the suggestion by copilot 🤷♂️
Description
Related issue (if applicable): fixes esphome/esphome#16671
Pull request in esphome with YAML changes (if applicable):
Checklist
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/src/content/docs/components/index.mdxwhen creating new documents for new components or cookbook.New Component Images
If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.
To generate a component image:
Comment on this pull request with the following command, replacing
component_namewith your component name in lower_case format with underscores (e.g.,bme280,sht3x,dallas_temp):The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.
Extract the SVG file and place it in the
/public/images/folder of this repository.Use the image in your component's index table entry in
/src/content/docs/components/index.mdx.Example: For a component called "DHT22 Temperature Sensor", use:
Note: All images used in ImgTable components must be placed in
/public/images/as the component resolves them to absolute paths.