Open
Conversation
|
|
Collaborator
|
Hello @udoudou , Would it be possible to explain the change in some kind of write up? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added flow control for wifi packets. This will greatly reduce the packet loss rate (tested by sending udp via iperf). But it only supports the sdio interface because I think the current spi communication implementation is not compatible with the flow control mechanism. At the same time, when I checked the spi communication, I found that there are still some problems:
The number of SPI memory pools is only SPI_MEMPOOL_NUM_BLOCKS, but the number of spi_tx_queue and spi_rx_queue queues is three times that. I think in extreme cases, when the memory pool is exhausted and all the memory is in spi_rx_queue/spi_tx_queue, the next spi transmission will fail to apply for memory, triggering assert