Drilldown url#1
Open
Edaurd wants to merge 40 commits into
Open
Conversation
still not able to save even though the code is a copy of the one i had before, still looking into it
i thought i fixed it yesterday morning but aparently i didn't, now i have for sure
[Your New Legend Label with {{job}} variables](https://your.url/{{instance}}/for/example)
This reverts commit 89636b0.
getUrl does not seem to be functioning as expected, it is not able to read the LegendUrlFormat from the config file yet
front end wise it seems to be working fine now, we can't know for certain untill we are able to pull form the config in the back end
No longer is this done with a constant and works fully as intended
… maintainability.
This commit introduces the necessary backend enhancements to enable drilldown links within Loki. The implementation follows a similar style of converting the url from the datasource as used in Prometheus
Applied the helper function to the formatName to avoid duplicate code
added the required fields to be able to save the url to the config
for both loki and prometheus
the current tests were failing due to this implementation, i solved it by changing how its adding the "..." at the end
This is so it wouldn't take too much screen real estate
still not able to save even though the code is a copy of the one i had before, still looking into it
i thought i fixed it yesterday morning but aparently i didn't, now i have for sure
[Your New Legend Label with {{job}} variables](https://your.url/{{instance}}/for/example)
This reverts commit 89636b0.
getUrl does not seem to be functioning as expected, it is not able to read the LegendUrlFormat from the config file yet
front end wise it seems to be working fine now, we can't know for certain untill we are able to pull form the config in the back end
No longer is this done with a constant and works fully as intended
… maintainability.
This commit introduces the necessary backend enhancements to enable drilldown links within Loki. The implementation follows a similar style of converting the url from the datasource as used in Prometheus
Applied the helper function to the formatName to avoid duplicate code
added the required fields to be able to save the url to the config
for both loki and prometheus
the current tests were failing due to this implementation, i solved it by changing how its adding the "..." at the end
This is so it wouldn't take too much screen real estate
…-group/grafana into DrilldownURL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Local Reasons
What is this feature?
Implements #1232
As of now users of Prometheus and Loki are able to create custom legend labels based on the labels of the metrics and this pull request adds an option to make those legend labels redirectable to a predefined url which can vary based on the same labels of the metrics, creating whats called a drilldown link.
Why do we need this feature?
It allows user defined drilldown urls within Prometheus and Loki for easier navigation.
Who is this feature for?
For users of the dashboard who would like to navigate between their panels more easily
Which issue(s) does this PR fix?:
Fixes grafana#1232
Notes:
Planned:
Special notes for your reviewer:
Please check that:
Visualization:
Prometheus:
Loki: