perf: cache validated struct constructors - #145
Open
ShadowSpatula wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developThis adapts the constructor-cache approach from PR #70 to the current runtime, alongside the newer field-index cache.
Results
bench_struct_records.nximproved from a 107.9 ms median to 51.7 ms (-52.1%) across 11 interleaved runs. Baseline and candidate checksums matched.Verification
go build ./...go vet ./...go test ./internal/... -count=1go run ./cmd/noxy --sync --lockedgo run ./cmd/noxy noxy_examples/run_all_tests_concurrent.nx— 185/185 passedgo test -race ./internal/vm -run TestStructConstructor -count=1— passed on Linuxsys.execharness failures on this branch and untoucheddevelop, with no race reportRisk
Only successful constructor-schema validation is cached. The cache is atomic for concurrent task reads and is ignored if
ConstructorTypeno longer matches the cached schema.AI assistance was used to research the historical patch, adapt it to the current tree, and run verification. I reviewed the resulting code, tests, and benchmark evidence.
Fixes #100