fix: report reformatted failpoint header instead of panicking - #161
Open
AruneshDwivedi wants to merge 2 commits into
Open
fix: report reformatted failpoint header instead of panicking#161AruneshDwivedi wants to merge 2 commits into
AruneshDwivedi wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AruneshDwivedi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
When gofmt reformats a failpoint header across multiple lines, the type assertion lands on a later line than the 'if'. ToComments would panic with index out of range when trying to extract the type from the header line. Return a descriptive error instead, preventing the crash and the wedged .tmp file that leaves the tool unusable until manually cleaned up. Fixes etcd-io#158 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
force-pushed
the
fix-report-reformatted-failpoint-header
branch
from
August 29, 2026 06:13
36eed0b to
feff108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gofmt reformats a failpoint header across multiple lines, the type assertion lands on a later line than the if. ToComments would panic with index out of range when trying to extract the type from the header line. This fix returns a descriptive error instead, preventing the crash and the wedged .tmp file.
Fixes #158