Fix bugs in adapters, test setup, exceptions, and CI config#7
Merged
Conversation
- PhpRedisAdapter::connect(): guard auth() behind null check to avoid "ERR Client sent AUTH, but no password is set" on password-less Redis - PhpRedisAdapter::rawCommand(): call validateRawCommandResults() after the try/catch so string error responses (e.g. "cannot create index on db != 0") are validated and throw UnsupportedRedisDatabaseException, consistent with PredisAdapter and RedisClientAdapter - AbstractTestCase::setUp(): replace ?? with ?: for REDIS_HOST/PORT/DB fallbacks since getenv() returns false (not null) when unset - Exception constructors: change Exception \$previous = null to ?\Throwable \$previous = null to match parent signature and accept any Throwable as a cause - CI: set IS_LOGGING_ENABLED to empty string instead of YAML false; YAML false becomes string "false" in env vars which PHP treats as truthy https://claude.ai/code/session_01TAZxBvfTTM5rk51ZoJYEjm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.