Skip to content

op-deployer: deprecate non-forge artifact setup #18346

Closed

Description

@serpixel

Description
With forge now we're requiring the entire folder to be present (with the solidity source files). We still have code in op-deployer that supports loading non-forge compatible artifacts, which would ultimately fail to work.

Activity

  1. added
    M-needs-triageMeta: this issue needs to be labelled
    and removed
    M-needs-triageMeta: this issue needs to be labelled
    on Nov 20, 2025
  2. sebastianst commented on Oct 15, 2026

    @sebastianst
    Member

    🤖 Opus 5.5 says: Superseded by #23308 (forge-only cutover, part of #23300).

  3. OptimismBot commented on Oct 15, 2026

    @OptimismBot

    @sebastianst Reopening because this issue was closed but there are still TODOs referencing it in the codebase.

    This was closed as superseded by #23308, but the non-forge artifact path these TODOs describe hasn't been removed yet. Either keep this open until the cutover lands, or repoint the TODOs to #23308 and close it again.

    The TODOs at op-deployer/pkg/deployer/artifacts/download.go:86, download.go:131, op-deployer/pkg/deployer/artifacts/embedded.go:59 and embedded.go:103 are still present:

    // download.go:86
    // TODO(#18346): Accept this for now but in the future we should error
    // download.go:131, embedded.go:59, embedded.go:103
    // TODO(#18346): Change this to provide the parent directory of the forge-artifacts directory

    Discovered by the TODO check in CI: https://circleci.com/gh/ethereum-optimism/optimism/5713135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions