Skip to content

opgeth-decoupling: remove deprecated ProtocolVersions watching from op-node #20258

Closed

Description

@sebastianst

Part of #20257. See plan §0 in the op-geth decoupling doc.

Goal

Delete the deprecated protocol-versions signalling mechanism from op-node so we don't need to port its op-geth types (params.ProtocolVersion*, catalyst.SuperchainSignal, catalyst.LogProtocolVersionSupport, params.OPStackSupport) into op-core.

Scope

  • Delete op-node/node/superchain.go (handleProtocolVersionsUpdate, haltMaybe).
  • op-node/node/runcfg/runtime_config.go: remove ProtocolVersion fields on runtimeConfigData, the RequiredProtocolVersion() / RecommendedProtocolVersion() methods, RequiredProtocolVersionStorageSlot / RecommendedProtocolVersionStorageSlot constants, and the corresponding ReadStorageAt calls in Load. Keep everything related to the unsafe block signer — P2P gossip needs that.
  • op-node/node/node.go: remove the handleProtocolVersionsUpdate(ctx) call and related rollupHalt / halted wiring.
  • op-node/service.go: remove the block that clears ProtocolVersionsAddress when the load flag is unset.
  • op-node/flags/flags.go: remove RollupLoadProtocolVersions and RollupHalt flags.
  • op-node/rollup/types.go: remove Config.ProtocolVersionsAddress.
  • op-node/rollup/superchain.go: remove OPStackSupport var; stop copying ProtocolVersionsAddr.
  • op-node/metrics/metrics.go + noop.go: remove ReportProtocolVersions, ProtocolVersionDelta, ProtocolVersions gauges.
  • op-service/sources/engine_client.go: remove SignalSuperchainV1.

Leave alone (same name, different concept): op-service/apis/p2p.go ProtocolVersion string and op-node/p2p/rpc_server.go libp2p peerstore "ProtocolVersion" reads.

Dependencies

None. Can start immediately.

🤖 Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions