You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
opgeth-decoupling: swap DepositTx construction + Transaction-method helpers in op-node #20269
Swap op-node (and remaining op-service/op-batcher) DepositTx construction/decoding and fork Transaction-method calls to op-core/types / op-core/fees:
types.NewTx(&types.DepositTx{...}).MarshalBinary() → optypes.DepositTx{...}.MarshalBinary() — struct straight to bytes, the *types.Transaction wrapper is eliminated. UnmarshalDepositLogEvent returns *optypes.DepositTx.
Fork Transaction methods → op-core helpers: tx.IsDepositTx() → optypes.IsDepositTx(tx); tx.SourceHash() / tx.Mint() / tx.IsSystemTx() → decode via optypes.UnmarshalDepositTx and read fields; tx.RollupCostData() → opfees.TxRollupCostData(tx). These helpers are transition scaffolding, deleted at the cutover (doc §2).
Derive the current call-site list by grep (types\.DepositTx{, the method names above on go-ethereum types) — sites cluster in op-node derivation (one *_upgrade_transactions.go per fork; the set grows with every fork) and interop indexing. Don't trust any snapshot list.
Acceptance criteria
No in-scope package constructs or decodes go-ethereum's types.DepositTx or calls the fork Transaction methods; a grep over the go-ethereum import is clean outside op-core.
Behaviour unchanged — byte-identical encodings, pinned by the op-core differential tests.
Activity
op-node/op-service/op-batcher: swap DepositTx + Transaction-method he…
op-node/op-service/op-batcher: swap DepositTx + Transaction-method he…
op-node/op-service/op-batcher: swap DepositTx + Transaction-method he…