Repository navigation
Closed
2 / 22 of 2 issues completedClosed
2 / 22 of 2 issues completed
Copy link
Description
Part of #20263 → #20257. See plan §4, §7, §8 in the op-geth decoupling doc.
Scope
- eip1559 — broken out into sub-issue opgeth-decoupling: wire op-node onto op-core/eip1559 and op-service/txinclude onto op-core/fees #21500: switch imports in all op-node consumers (
rollup/derive/payload_util.go,rollup/attributes/engine_consolidate.go,rollup/derive/system_config.go, plusengine_consolidate_test.go) fromgithub.com/ethereum/go-ethereum/consensus/misc/eip1559togithub.com/ethereum-optimism/optimism/op-core/eip1559, and add the missingValidateOptimismExtraDatahelper toop-core/eip1559. (Therollup/interop/indexing/attributes.gosite originally listed here no longer uses eip1559;system_config.godoes.) See opgeth-decoupling: wire op-node onto op-core/eip1559 and op-service/txinclude onto op-core/fees #21500. - superchain — broken out into sub-issue opgeth-decoupling: wire op-core/superchain across the monorepo (decouple from op-geth superchain) #21485: swap all
github.com/ethereum/go-ethereum/superchainconsumers toop-core/superchain(op-node, op-challenger, op-deployer, op-dispute-mon, op-chain-ops/check-prestate, op-core/interop/depset — not just the two op-node files originally listed here), remove the op-geth cross-check ininit.goand the differential test, deleteop-service/superutil/and migrate op-simulate, and wire thesuperchain-configs.zipbuild prerequisite. See opgeth-decoupling: wire op-core/superchain across the monorepo (decouple from op-geth superchain) #21485 for the full scope. - fees — broken out into sub-issue opgeth-decoupling: wire op-node onto op-core/eip1559 and op-service/txinclude onto op-core/fees #21500: in
op-service/txinclude/txbudget.go+cost_oracle.go(formerlyisthmus_cost_oracle.go), replacetypes.NewL1CostFuncFjordwithopfees.NewL1CostFuncFjordandtx.RollupCostData()withopfees.TxRollupCostData(tx). The inline operator-fee math was already migrated toopfees.OperatorCostJovianin a prior change. (op-batcher/batcher/types.go'stx.RollupCostData()swap stays with the op-batcher →op-service/sourcesmigration in §11.) See opgeth-decoupling: wire op-node onto op-core/eip1559 and op-service/txinclude onto op-core/fees #21500.
The op-core packages these swaps depend on are all landed: #20267 (op-core/superchain), #20268 (op-core/eip1559), #20261 (op-core/fees) — all closed.
Note on sync-superchain prerequisites (added during #20314 review)
Resolved in #21485. When op-core/superchain is swapped in, op-node and ~13 other binaries start embedding superchain-configs.zip (gitignored) at compile time. Rather than auditing every just recipe and Dockerfile individually (the original plan below), #21485 regenerates the zip inside the shared op-stack-go Docker builder stage from the superchain-registry submodule data, git-free, verified against the committed .sha256; the justfile build-go/CI prerequisites are wired there too.
Original audit note (superseded)
justrecipes: every recipe that builds Go code importingop-core/superchain(op-node, op-batcher, op-proposer, op-challenger, op-supernode, op-faucet, etc.) needssync-superchainas a prerequisite. Right now those recipes are:op-node,op-batcher,op-proposer,op-challenger,op-program-client,op-program-host,cannon-prestates,make-pre-test,op-program, etc. Audit each injustfileand addsync-superchainto the prereq list.- Docker builds: any Dockerfile that runs
go build ./...or builds a binary that linksop-core/superchainneeds the zip in its build context. Either:- Run
just sync-superchainin the Dockerfile beforego build, or - Bake the zip into the build context (rebuild the image when the pinned commit bumps).
- Audit
op-batcher/Dockerfile,op-node/Dockerfile,op-proposer/Dockerfile,op-challenger/Dockerfile,op-conductor/Dockerfile,op-supernode/Dockerfile,op-faucet/Dockerfile, plus theOP_STACK_GO_BUILDERupstream image.
- Run
🤖 Generated by Claude Code
Metadata
Metadata
Assignees
Labels
No labels
Activity
refactor(superchain): migrate monorepo importers to op-core/superchain
op-core: wire op-node onto op-core/eip1559 and txinclude onto op-core…
op-core: wire op-node onto op-core/eip1559 and txinclude onto op-core…