You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
opgeth-decoupling: split op-e2e/e2eutils/geth/wait.go into header-only and full-block variants #20272
Part of #20265 → #20257. See plan §11 and §13. This issue covers the shared op-e2e helpers that read L2 data. The call sites that use them are in #20273. Follow the sources-client rules in #20265, with #23417 as the worked example.
Problem
The helpers compile against upstream go-ethereum but break at runtime on L2:
Full-block fetches fail on the deposit (0x7E) and post-exec (0x7D) txs.
Upstream types.Receipt silently drops the OP receipt fields, which tests read.
WaitForBlock, WaitForBlockToBeSafe and WaitForBlockToBeFinalized fetch full blocks. Nearly every caller discards the result or reads only header fields, so return *types.Header via HeaderByNumber.
WaitForL1OriginOnL2 reads the L1-info deposit and should use InfoAndFirstDeposit.
WaitForTransaction should return *optypes.Receipt when waiting on L2.
WaitUntilTransactionNotFound uses only the receipt lookup and needs nothing.
wait/blocks.go:BlockCaller requires BlockByNumber, and ForNextSafeBlock and ForBlockWithTimestamp use it against L2 sequencers. Switch them to headers.
Receipt helpers: these return upstream *types.Receipt, and their callers read OP fields such as L1Fee and the operator-fee fields.
🤖 Fable says: Done by #23862: the wait helpers return headers, ForOPReceipt* return *optypes.Receipt, and e2esys.System.NodeSourceClient is the owned per-node sources client. One deviation from the text above: WaitForTransaction still returns *types.Receipt, because its callers read only Status. A forbidigo rule now rejects ethclient body, tx and receipt reads in the test trees.
Activity
sebastianst commentedon Nov 12, 2026
🤖 Fable says: Done by #23862: the wait helpers return headers,
ForOPReceipt*return*optypes.Receipt, ande2esys.System.NodeSourceClientis the owned per-node sources client. One deviation from the text above:WaitForTransactionstill returns*types.Receipt, because its callers read onlyStatus. Aforbidigorule now rejectsethclientbody, tx and receipt reads in the test trees.